Can someone take a look please?

[boke]

It works but its so long and ugly I figure there has to be a better way. I have one movie clip with 36 other movie clips inside that act as the card faces. Scroll down till you see "the long ugly mess"

package {
import flash.display.*;
import flash.events.*;
import flash.text.*;
import flash.utils.getTimer;
import flash.utils.Timer;
import flash.media.Sound;
import flash.media.SoundChannel;

public class MatchingGameObject10b extends MovieClip {
// game constants
private static const boardWidth:uint = 6;
private static const boardHeight:uint = 6;
private static const cardHorizontalSpacing:Number = 52;
private static const cardVerticalSpacing:Number = 52;
private static const boardOffsetX:Number = 145;
private static const boardOffsetY:Number = 70;
private static const pointsForMatch:int = 100;
private static const pointsForMiss:int = -5;

// variables
private var firstCard:Card10;
private var secondCard:Card10;
private var cardsLeft:uint;
private var gameScore:int;
private var gameStartTime:uint;
private var gameTime:uint;

// text fields
private var gameScoreField:TextField;
private var gameTimeField:TextField;

// timer to return cards to face-down
private var flipBackTimer:Timer;

// set up sounds
var theFirstCardSound:FirstCardSound = new FirstCardSound();
var theMissSound:MissSound = new MissSound();
var theMatchSound:MatchSound = new MatchSound();

// initialization function
public function MatchingGameObject10b():void {
// make a list of card numbers
var cardlist:Array = new Array();
for(var i:uint=0;i<boardWidth*boardHeight;i++) {
cardlist.push(i);

}

// create all the cards, position them, and assign a randomcard face to each
cardsLeft = 0;
for(var x:uint=0;x<boardWidth;x++) { // horizontal
for(var y:uint=0;y<boardHeight;y++) { // vertical
var c:Card10 = new Card10(); // copy the movie clip
c.stop(); // stop on first frame
c.x = x*cardHorizontalSpacing+boardOffsetX; // set position
c.y = y*cardVerticalSpacing+boardOffsetY;
var r:uint = Math.floor(Math.random()*cardlist.length); // get a random face
c.cardface = cardlist[r]; // assign face to card
cardlist.splice(r,1); // remove face from list
c.addEventListener(MouseEvent.CLICK,clickCard); // have it listen for clicks
c.buttonMode = true;
addChild(c); // show the card
cardsLeft++;
}
}

// set up the score
gameScoreField = new TextField();
addChild(gameScoreField);
gameScore = 0;
showGameScore();

// set up the clock
gameTimeField = new TextField();
gameTimeField.x = 450;
addChild(gameTimeField);
gameStartTime = getTimer();
gameTime = 0;
addEventListener(Event.ENTER_FRAME,showTime);
}

// player clicked on a card
public function clickCard(event:MouseEvent) {
var thisCard:Card10 = (event.target as Card10); // what card?

if (firstCard == null) { // first card in a pair
firstCard = thisCard; // note it
thisCard.startFlip(thisCard.cardface+2);
playSound(theFirstCardSound);

} else if (firstCard == thisCard) { // clicked first card again
firstCard.startFlip(1);
firstCard = null;
playSound(theMissSound);

} else if (secondCard == null) { // second card in a pair
secondCard = thisCard; // note it
thisCard.startFlip(thisCard.cardface+2);

// compare two cards ( and here is the long ugly mess)
if (firstCard.cardface == 1 && secondCard.cardface == 0 || firstCard.cardface == 0 && secondCard.cardface == 1 || firstCard.cardface == 2 && secondCard.cardface == 3 || firstCard.cardface == 3 && secondCard.cardface == 2 || firstCard.cardface == 4 && secondCard.cardface == 5 || firstCard.cardface == 5 && secondCard.cardface == 4 || firstCard.cardface == 6 && secondCard.cardface == 7 || firstCard.cardface == 7 && secondCard.cardface == 6 || firstCard.cardface == 8 && secondCard.cardface == 9 || firstCard.cardface == 9 && secondCard.cardface == 8 || firstCard.cardface == 10 && secondCard.cardface == 11 || firstCard.cardface == 11 && secondCard.cardface == 10 || firstCard.cardface == 12 && secondCard.cardface == 13 || firstCard.cardface == 13 && secondCard.cardface == 12 || firstCard.cardface == 14 && secondCard.cardface == 15 || firstCard.cardface == 15 && secondCard.cardface == 14 || firstCard.cardface == 16 && secondCard.cardface == 17 || firstCard.cardface == 17 && secondCard.cardface == 16 || firstCard.cardface == 18 && secondCard.cardface == 19 || firstCard.cardface == 19 && secondCard.cardface == 18 || firstCard.cardface == 20 && secondCard.cardface == 21 || firstCard.cardface == 21 && secondCard.cardface == 20 || firstCard.cardface == 22 && secondCard.cardface == 23 || firstCard.cardface == 23 && secondCard.cardface == 22 || firstCard.cardface == 24 && secondCard.cardface == 25 || firstCard.cardface == 25 && secondCard.cardface == 24 || firstCard.cardface == 26 && secondCard.cardface == 27 || firstCard.cardface == 27 && secondCard.cardface == 26 || firstCard.cardface == 28 && secondCard.cardface == 29 || firstCard.cardface == 29 && secondCard.cardface == 28 || firstCard.cardface == 30 && secondCard.cardface == 31 || firstCard.cardface == 31 && secondCard.cardface == 30 ||firstCard.cardface == 32 && secondCard.cardface == 33 || firstCard.cardface == 33 && secondCard.cardface == 32 || firstCard.cardface == 34 && secondCard.cardface == 35 || firstCard.cardface == 35 && secondCard.cardface == 34 ) {
// remove a match
removeChild(firstCard);
removeChild(secondCard);
// reset selection
firstCard = null;
secondCard = null;
// add points
gameScore += pointsForMatch;
showGameScore();
playSound(theMatchSound);
// check for game over
cardsLeft -= 2; // 2 less cards
if (cardsLeft == 0) {
MovieClip(root).gameScore = gameScore;
MovieClip(root).gameTime = clockTime(gameTime);
MovieClip(root).gotoAndStop("gameover");
}
} else {
gameScore += pointsForMiss;
showGameScore();
playSound(theMissSound);
flipBackTimer = new Timer(2000,1);
flipBackTimer.addEventListener(TimerEvent.TIMER_CO MPLETE,returnCards);
flipBackTimer.start();
}

} else { // starting to pick another pair
returnCards(null);
playSound(theFirstCardSound);
// select first card in next pair
firstCard = thisCard;
firstCard.startFlip(thisCard.cardface+2);
}
}

// return cards to face-down
public function returnCards(event:TimerEvent) {
firstCard.startFlip(1);
secondCard.startFlip(1);
firstCard = null;
secondCard = null;
flipBackTimer.removeEventListener(TimerEvent.TIMER _COMPLETE,returnCards);
}

public function showGameScore() {
gameScoreField.text = "Score: "+String(gameScore);
}

public function showTime(event:Event) {
gameTime = getTimer()-gameStartTime;
gameTimeField.text = "Time: "+clockTime(gameTime);
}

public function clockTime(ms:int) {
var seconds:int = Math.floor(ms/1000);
var minutes:int = Math.floor(seconds/60);
seconds -= minutes*60;
var timeString:String = minutes+":"+String(seconds+100).substr(1,2);
return timeString;
}

public function playSound(soundObject:Object) {
var channel:SoundChannel = soundObject.play();
}
}
}

[Jim Freer]

Compared to a lot of code I see in here I wouldn't say it is all that ugly. For myself, I would find it difficult to build a game inside of 1 class because I've trained my self to break things into small pieces. However, whenever a program is done on time and it has all of the functionality required it is a thing of beauty.

But here is the catch. Does is do everything you want it to do? What happens if there is still a missing feature you need. When you tack in new features is it going to get ugly?

On the other hand, don't feel it is necessary to build something so well designed that it can take any new feature that may come along. I think more time is wasted building in flexibility that will never be needed. Trying to do this is a sure fire reason for things never getting done.

Jim Freer
http://freerpad.blogspot.com